Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Fix comment parsing to support multiple comments #672

Merged
merged 1 commit into from
Aug 25, 2024
Merged

[BUGFIX] Fix comment parsing to support multiple comments #672

merged 1 commit into from
Aug 25, 2024

Conversation

oliverklee
Copy link
Contributor

Because of an eager consumption of whitespace, the rule parsing would swallow a trailing comment, meaning the comment for the next rule would be affected. This patch addresses this by only consuming real whitespace without comments after a rule.

Fixes #173

@ziegenberg @oliverklee
[BUGFIX] Fix comment parsing to support multiple comments
a855250 
Because of an eager consumption of whitespace, the rule parsing would
swallow a trailing comment, meaning the comment for the next rule would
be affected. This patch addresses this by only consuming real whitespace
without comments after a rule.

Fixes #173

Signed-off-by: Daniel Ziegenberg <[email protected]>
@oliverklee oliverklee added the bug label Aug 25, 2024
@oliverklee oliverklee self-assigned this Aug 25, 2024
@oliverklee oliverklee enabled auto-merge (squash) August 25, 2024 21:23
@oliverklee oliverklee disabled auto-merge August 25, 2024 21:25
@oliverklee oliverklee merged commit e4c66f6 into main Aug 25, 2024
18 checks passed
@oliverklee oliverklee deleted the bugfix/forward-port branch August 25, 2024 21:25
This was referenced Aug 25, 2024
Merged
Open
oliverklee added a commit that referenced this pull request Oct 23, 2024
@oliverklee
[BUGFIX] Revert broken support for multiple comments
a1a9a61 
This reverts e4c66f6 (#672), which
broke comment parsing in strict mode.

We'll need to re-implement support for multiple comments later
in a way that does not break the existing comment parsing.
@oliverklee oliverklee mentioned this pull request Oct 23, 2024
Merged
JakeQZ pushed a commit that referenced this pull request Oct 24, 2024
@oliverklee
[BUGFIX] Revert broken support for multiple comments (#740)
a5a1f1a 
This reverts e4c66f6 (#672), which
broke comment parsing in strict mode.

We'll need to re-implement support for multiple comments later
in a way that does not break the existing comment parsing.
oliverklee added a commit that referenced this pull request Oct 24, 2024
@oliverklee
[BUGFIX] Revert broken support for multiple comments
09635e6 
This reverts e4c66f6 (#672), which broke comment parsing in
strict mode.

We'll need to re-implement support for multiple comments later
in a way that does not break the existing comment parsing.

This is the v8.x backport of #740.
@oliverklee oliverklee mentioned this pull request Oct 24, 2024
Merged
JakeQZ pushed a commit that referenced this pull request Oct 24, 2024
@oliverklee
[BUGFIX] Revert broken support for multiple comments (#741)
81582a7 
This reverts e4c66f6 (#672), which broke comment parsing in
strict mode.

We'll need to re-implement support for multiple comments later
in a way that does not break the existing comment parsing.

This is the v8.x backport of #740.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oliverklee oliverklee

Labels
bug
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.

bug with parsing multiple comments
2 participants
@oliverklee @ziegenberg